Skip to content

Fix parameter names #5539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
conniey merged 3 commits into from
Sep 25, 2019
Merged

Fix parameter names #5539

conniey merged 3 commits into from
Sep 25, 2019

Conversation

@conniey
Copy link
Member

@conniey conniey commented Sep 25, 2019

  • Change ExpandableStringEnum.values to getValues to follow our Java spec
  • Change parameter name from getNew to tokenSupplier.

alzimmermsft
alzimmermsft approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@alzimmermsft alzimmermsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AccessTierRequired and AccessTierOptional were deleted in a recent PR

@conniey conniey merged commit 3edaf1c into Azure:master Sep 25, 2019
@conniey conniey deleted the fixNames branch September 25, 2019 23:23
@JonathanGiles
Copy link
Member

JonathanGiles commented Sep 26, 2019

Hmm, there was a communication breakdown here. I spoke with @samvaity about this earlier and said to not do the values() rename - this is actually just recreating the standard values() method on enum types, so it made sense to leave it as is.

conniey added a commit to conniey/azure-sdk-for-java that referenced this pull request Sep 26, 2019
@conniey
Revert "Fix parameter names (Azure#5539)"
0abb59d 
This reverts commit 3edaf1c.
@conniey conniey mentioned this pull request Sep 26, 2019
Merged
@conniey
Copy link
Member Author

conniey commented Sep 26, 2019

@JonathanGiles #5555 Its reverted here.

@conniey conniey self-assigned this Sep 26, 2019
@conniey conniey added the Client This issue points to a problem in the data-plane of the library. label Sep 26, 2019
conniey added a commit that referenced this pull request Sep 26, 2019
@conniey
Revert "Fix parameter names (#5539)" (#5555)
52bd42b 
This reverts commit 3edaf1c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@gapra-msft gapra-msft Awaiting requested review from gapra-msft

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@rickle-msft rickle-msft Awaiting requested review from rickle-msft

@sima-zhu sima-zhu Awaiting requested review from sima-zhu

@srnagar srnagar Awaiting requested review from srnagar

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

Assignees

@conniey conniey

Labels

Client This issue points to a problem in the data-plane of the library.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@conniey @JonathanGiles @alzimmermsft